#7396 changing columns does not log status changes#183
Open
farukvukovic wants to merge 2 commits into
Open
Conversation
Introduce logStatusChangeActivity() to write human-readable status changes to zp_ticket_status_changes using TicketHistoryModel. Co-authored-by: Cursor <cursoragent@cursor.com>
Detect status changes on the dragged ticket during kanban sort updates and write them to zp_ticket_status_changes via logStatusChangeActivity(). Co-authored-by: Cursor <cursoragent@cursor.com>
farukvukovic
changed the title
📝 WalkthroughWalkthroughKanban ticket updates now capture the moved ticket’s previous state, compare it after bulk updates, and log changed statuses in ticket history using resolved status labels. ChangesTicket status history
Estimated code review effort: 2 (Simple) | ~10 minutes Sequence Diagram(s)sequenceDiagram
participant Kanban as Kanban update flow
participant Tickets as Ticket model
participant Logger as logStatusChangeActivity
participant History as TicketHistoryModel
Kanban->>Tickets: Load handler ticket and capture prior status
Kanban->>Tickets: Apply bulk status updates
Kanban->>Tickets: Reload updated ticket
Kanban->>Logger: Log changed status
Logger->>History: Persist status-select activity
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
app/Domain/Tickets/Services/Tickets.php (1)
2048-2050: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winComplete the phpDoc for the new helper.
The doc block omits
@param/@return. Add them to satisfy the project's phpDoc standard.📝 Proposed phpDoc
/** * Log a kanban status change to the ticket activity history. + * + * `@param` int $ticketId The ticket whose status changed. + * `@param` int $oldStatus The previous status id. + * `@param` int $newStatus The new status id. + * `@param` int $projectId The project id used to resolve status labels. */ private function logStatusChangeActivity(As per coding guidelines: "Add valid phpDoc comments to all methods and classes".
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@app/Domain/Tickets/Services/Tickets.php` around lines 2048 - 2050, Complete the phpDoc for the new kanban status-change helper by adding valid `@param` tags for every method argument and an `@return` tag matching the method’s return type, following the project’s existing documentation conventions.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@app/Domain/Tickets/Services/Tickets.php`:
- Around line 2048-2050: Complete the phpDoc for the new kanban status-change
helper by adding valid `@param` tags for every method argument and an `@return` tag
matching the method’s return type, following the project’s existing
documentation conventions.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 65a94133-509f-43a6-8fdc-f13896608fa6
📒 Files selected for processing (1)
app/Domain/Tickets/Services/Tickets.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves: http://pearlog.pearshadow.com/tickets/showKanban?tab=ticketdetails#/tickets/showTicket/7396